Skip to content

Support to plug-and-play external (CAD) geometry#15064

Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel:swenzel/cad-geometry-support
Feb 13, 2026
Merged

Support to plug-and-play external (CAD) geometry#15064
sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel:swenzel/cad-geometry-support

Conversation

@sawenzel
Copy link
Collaborator

@sawenzel sawenzel commented Feb 12, 2026

This commit adds support for

  • conversion from CAD geometries (STEP) file to (meshed) TGeo geometry via the tool O2_CADtoTGeo.py

  • ability to setup and include simulations modules from external geometries via the ExternalModule mechanism

  • ability to navigate complex TGeoTessellated solids efficiently (will stay here until fully integrated in the official ROOT repo)

It includes all the (basic) functionality to pick a detector layout from a CAD design and actually simulate it with o2-sim.

Instructions are provided in a dedicated documentation markdown.

The commit is related to epic https://its.cern.ch/jira/browse/O2-6616

@sawenzel sawenzel requested review from a team and shahor02 as code owners February 12, 2026 13:06
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild alibuild mentioned this pull request Feb 12, 2026
Closed
@sawenzel sawenzel force-pushed the swenzel/cad-geometry-support branch 3 times, most recently from e423cb0 to 32d785a Compare February 12, 2026 13:18
@sawenzel
Copy link
Collaborator Author

sawenzel commented Feb 12, 2026

Tiny teaser
image

@sawenzel
Copy link
Collaborator Author

sawenzel commented Feb 12, 2026

@qgp @plariono @mconcas @njacazio @atriolo : Maybe someone could try it out and provide feedback. Instructions are in the markdown files.

@sawenzel sawenzel force-pushed the swenzel/cad-geometry-support branch from 32d785a to 42ddb4a Compare February 12, 2026 14:26
@sawenzel
Support to plug-and-play external (CAD) geometry
817aae0 
This commit adds support for

- conversion from CAD geometries (STEP) file to (meshed) TGeo geometry
  via the tool O2_CADtoTGeo.py

- ability to setup and include simulations modules from external geometries
  via the ExternalModule mechanism

- ability to navigate complex TGeoTessellated solids efficiently
  (will stay here until fully integrated in the official ROOT repo)

It includes all the (basic) functionality to pick a detector layout from
a CAD design and actually simulate it with o2-sim.

Instructions are provided in a dedicated documentation markdown.

The commit is related to epic https://its.cern.ch/jira/browse/O2-6616
@sawenzel sawenzel force-pushed the swenzel/cad-geometry-support branch from 42ddb4a to 817aae0 Compare February 13, 2026 09:03
@AliceO2Group AliceO2Group deleted a comment from alibuild Feb 13, 2026
@alibuild
Copy link
Collaborator

alibuild commented Feb 13, 2026

Error while checking build/O2/fullCI_slc9 for 42ddb4a at 2026-02-13 12:43:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:53:21: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:60:42: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:106:15: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:202:31: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:250:35: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:253:18: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:255:7: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:258:48: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:295:32: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:299:34: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:303:38: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:309:22: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:374:16: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:378:40: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:401:46: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:406:27: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:408:24: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:412:50: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:416:45: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:423:47: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:430:17: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:434:21: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:442:27: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:470:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:697:25: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:718:22: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:720:11: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:733:15: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:740:26: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15064-slc9_x86-64/0/Detectors/Base/src/O2Tessellated.cxx:742:9: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@sawenzel sawenzel merged commit 48c0b54 into AliceO2Group:dev Feb 13, 2026
11 checks passed
@sawenzel sawenzel deleted the swenzel/cad-geometry-support branch February 13, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sawenzel @alibuild